This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
fs: fix ReadStream / WriteStream fd leaks #4405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor nit about setting this.fd = null, but otherwise LGTM. (If there's some reason not to do that, then that's probably fine, too; it's an edge case.) |
Close the file descriptor when a read operation fails. Fixes nodejs#4387.
Close the file descriptor when a write operation fails. Fixes nodejs#4387.
|
@bnoordhuis Can you review 4791c32 and let me know if you think it's still a valid test for this issue? The timing of events in fd streams is a bit different in streams2, so the test needed a bit of refactoring. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4387. The PR is against master but it probably should go into v0.8.
Reviewer: @isaacs